Gracefully handle SocketTimeout when MLS not available

[MikeRatcliffe]

Fixes #684

[svillar]

Looking good, @MikeRatcliffe have you found a reliable way to reproduce it?

I hit that occasionally but now that I try to reproduce it I'm unable to. I tried disabling wifi, blocking DNS resolution on my router, shutting down the connection to my ISP... with no luck.

The backtrace is pretty clear anyway, but I just wanted to check whether simply managing the exception is enough, there might be other side effects, like what happens if we try to do a search after the location service failed...

[MikeRatcliffe]

@svillar

You are right. After some testing it appears that geolocation doesn't work even with the release version in the app store... I'll log a separate bug blocking this.

I tested using https://www.audero.it/demo/geolocation-api-demo.html

[svillar]

@MikeRatcliffe you have to give geolocation permissions to the app to get it working. I think that works fine.

Anyway my question was whether you have a reliable way to reproduce it, and check that it indeed does not add any side behaviour. Although it couldn't be worst than crashing...

[svillar]

Yeah, so the key is that Meta does not allow VR apps to ask for location permissions. So this cannot be reproduced in Meta devices. I'll try in Pico and others where it should be easy to reproduce.

[MikeRatcliffe]

Looking good, @MikeRatcliffe have you found a reliable way to reproduce it?

No, I couldn't find a way to replicate it. I chose to manually throw a SocketTimeoutException and made sure it was dealt with in the try / catch block.

With this patch, Wolvic starts up instead of throwing and bailing.

I didn't find any problems using search etc. when testing this.

[svillar]

Thanks!