Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some UI user experience #1017

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Improve some UI user experience #1017

merged 2 commits into from
Sep 27, 2023

Conversation

HollowMan6
Copy link
Collaborator

  • Make hint text visible in SingleEditSetting

Enable HintTextColor configuration in SingleEditSetting, set the text color to grey so that it's visible to user.

e.g. It can be hard for user to learn that we will actually reset the value in Homepage edit setting when we delete all the text.

Before:
com igalia wolvic-20230926-223849

After:
com igalia wolvic-20230926-223556

  • Set the prompt button hovering text color to be void, so that users can still see text clearly when doing so.

Before:
com igalia wolvic-20230926-223839

After:
com igalia wolvic-20230926-224000

Enable HintTextColor configuration in SingleEditSetting,
set the text color to grey so that it's visible to user.

e.g. It can be hard for user to learn that we will actually reset
the value in Homepage edit setting when we delete all the text
input there without seeing the hint text.

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
So that users can still see text clearly when doing so

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@svillar svillar merged commit b243e9b into main Sep 27, 2023
18 checks passed
@svillar svillar deleted the ui-experience branch September 27, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants