-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use horizontal layout for DateTime picker prompt #1018
Conversation
3db8335
to
1b67fb3
Compare
I find this sensible. @felipeerias what do you think? I just have doubts about hardcoding sizes of UI elements. In general I think we should use proportions or values that we can refer to some others, but not sure how feasible is that in Android UIs in general. |
Yeah, I agree, but since we are hardcoding basically all the sizes of UI elements, it won't be meaningful if we just change for this PR specifically: wolvic/app/src/main/res/values/dimen.xml Lines 150 to 159 in 1b67fb3
|
————————————— | | | | DATE | TIME | | | | ——————————————— | BUTTONS | ————————————— So that we don't need to scroll Resolve #998 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
1b67fb3
to
a5440bf
Compare
Kind of agree with @HollowMan6 and it's consistent with what we have. We could implement a refactoring to get rid of all the UI hardcoded values in a follow up patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK let's merge it then. I agree it looks much better without the scroll. Maybe for a future PR we could make the widgets smaller, they're too large for my taste, I don't think we need them to be that size, nor even with hand tracking I think. Anyway I'm deviating from the topic now :)
So that we don't need to scroll
Resolve #998