Use the the system's DeviceType for the generic input profile #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
requested changes
Sep 28, 2023
| if (mActiveMapping->controllerType == device::UnknownType) | ||
| delegate.SetControllerType(mIndex, DeviceUtils::GetDeviceTypeFromSystem(false)); | ||
| else | ||
| delegate.SetControllerType(mIndex, mActiveMapping->controllerType); |
There was a problem hiding this comment.
I prefer this to happen in OpenXRInputSource::Initialize(). We can directly modify the mapping that is added to the mMappings vector.
javifernandez
force-pushed
the
lynx-webxr-controllers
branch
from
490ed63
to
800b415
Compare
The generic input profile has the device::UknomnType enumeraton. This PR changes it by the one provided by Android.
javifernandez
force-pushed
the
lynx-webxr-controllers
branch
from
800b415
to
b4dfb9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic input profile is associated to the device::UnknownType which uses an empty VR controller in mozilla. The consequence is that there no controller is drawn during WebXR experiences for devices using the generic profile (eg Lynx).
This issue had been fixed already in PR #834, but it got reverted because it broke the logic to detect generic profiles as fallbacks (see PR #907)
The solution proposed in this PR is to assign the DeviceType provided by the system to the ControllerDelegate instance, instead of the one provided by the generic profile.
Fixes #833