Fix Chinese/Japanese keyboard typing #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chinese/Japanese keyboard typing is broken when you try to type in web pages We should use postInputCommand to wait for the mComposingText to be updated before we updateCandidates, otherwise we won't have anything in mComposingText when we type our first letter, causing input candidates to not display at all. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
We shouldn't empty mComposingText each time when we finished displayComposingText Signed-off-by: Songlin Jiang <sjiang@igalia.com>
We don't want to compose text again when we use voice input, e.g. Voice input English while keyboard layout is Chinese. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
|
@felipeerias @svillar @javifernandez Any review on this PR? This PR actually contains important fixes for the keyboards that compose text to input and I believe this should be treated with high priority. |
Closed
I'll try to review next week. I haven't reviewed it before because I know that code was modified for the chromium backend so I need to verify that the patch does not break the chromium backend. As my knowledge of JCK is null I'd need assistance to verify that precisely we don't regress the chromium backend |
javifernandez
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Chinese/Japanese keyboard typing is broken when you try to type in web pages.
We should use postInputCommand to wait for the mComposingText to be updated before we updateCandidates, otherwise we won't have anything in mComposingText when we type our first letter, causing input candidates to not display at all.
We shouldn't empty mComposingText each time when we finished displayComposingText
e.g. 测试一下
测 -> ce
试 -> shi
一 -> yi
下 -> xia
When we input
ceshiyixia, after we choose测试(ceshi),yixiashouldn't get dismissed and we should still be able to choose一下(yixia)Before: (quite annoying)
com.igalia.wolvic-20230929-204200.mp4
After: (the same behavior as most Chinese input methods)
com.igalia.wolvic-20230929-204338.mp4
We don't want to compose text again when we use voice input, e.g. Voice input English while keyboard layout is Chinese.