Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Android Component to 121.1.0 & AGP to 8.2.1 #1034

Merged
merged 1 commit into from Jan 24, 2024
Merged

Upgrade Android Component to 121.1.0 & AGP to 8.2.1 #1034

merged 1 commit into from Jan 24, 2024

Conversation

HollowMan6
Copy link
Collaborator

@HollowMan6 HollowMan6 commented Sep 30, 2023 •
edited

  • Upgrade Android Component version to 121.1.0
  • Upgrade AGP to 8.2.0

This was referenced Sep 30, 2023
Closed
Open
@HollowMan6 HollowMan6 force-pushed the gecko-118.1.0 branch 3 times, most recently from 165d844 to 0efcd1d Compare September 30, 2023 15:42
@HollowMan6 HollowMan6 changed the title Upgrade Gecko to 118.0.1 & AGP to 8.0.2 Upgrade Android Component to 118.1.0 & AGP to 8.0.2 Sep 30, 2023
@HollowMan6
Copy link
Collaborator Author

WARNING: This is not compatible with Gecko 116.0.3, we also need an upgrade of our Gecko version as well.

@HollowMan6 HollowMan6 force-pushed the gecko-118.1.0 branch 2 times, most recently from acc04b2 to 9f0a1e5 Compare September 30, 2023 16:02
javifernandez
javifernandez reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@javifernandez javifernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to review and test the change in detail, but first of all, could you add to the PR description the list of issues this change would fix ?

@HollowMan6
Copy link
Collaborator Author

Still need to review and test the change in detail, but first of all, could you add to the PR description the list of issues this change would fix ?

Unfortunately, originally I thought this PR would fix #353 and #598, but now it turns out that it doesn't fix anything. The only advantage of using Gecko & AC 118 is that it finally allows us to land on AGP 8. I think we can track this PR later and I will continue checking the newer gecko version / fixing the error that stops us from upgrading to AGP 8.1.0

@svillar
Copy link
Member

svillar commented Oct 4, 2023

Still need to review and test the change in detail, but first of all, could you add to the PR description the list of issues this change would fix ?

Unfortunately, originally I thought this PR would fix #353 and #598, but now it turns out that it doesn't fix anything. The only advantage of using Gecko & AC 118 is that it finally allows us to land on AGP 8. I think we can track this PR later and I will continue checking the newer gecko version / fixing the error that stops us from upgrading to AGP 8.1.0

should we move it to draft then?

@HollowMan6 HollowMan6 marked this pull request as draft October 4, 2023 15:00
@HollowMan6 HollowMan6 changed the title Upgrade Android Component to 118.1.0 & AGP to 8.0.2 Upgrade Android Component to 119.1.1 & AGP to 8.0.2 Nov 19, 2023
@HollowMan6 HollowMan6 changed the title Upgrade Android Component to 119.1.1 & AGP to 8.0.2 Upgrade Android Component to 120.0 & AGP to 8.0.2 Nov 19, 2023
@svillar
Copy link
Member

svillar commented Nov 27, 2023

@HollowMan6 it's great that you keep updating this. Don't feel ignored I keep following this work, actually perhaps 120 is a great candidate for the next Gecko update for early next year

@HollowMan6
Copy link
Collaborator Author

Actually perhaps 120 is a great candidate for the next Gecko update for early next year

Actually I won't recommend 120 as they currently have some issues with playing YouTube in desktop mode (e.g. https://www.youtube.com/watch?v=czjisEGe5Cw&app=desktop, when appended with &app=desktop, video won't display at all), this is also reproducible in Firefox Android. Anyway, let's see how it goes by then.

image

@HollowMan6 HollowMan6 changed the title Upgrade Android Component to 120.0 & AGP to 8.0.2 Upgrade Android Component to 120.1.0 & AGP to 8.0.2 Dec 11, 2023
@HollowMan6
Copy link
Collaborator Author

Actually perhaps 120 is a great candidate for the next Gecko update for early next year

Actually I won't recommend 120 as they currently have some issues with playing YouTube in desktop mode

This is fixed now in geckoview 120.0.1

@svillar
Copy link
Member

svillar commented Dec 11, 2023 •
edited

Actually perhaps 120 is a great candidate for the next Gecko update for early next year

Actually I won't recommend 120 as they currently have some issues with playing YouTube in desktop mode

This is fixed now in geckoview 120.0.1

Nice!, I think we should really switch to 120 for 1.6. @felipeerias WDYT? Perhaps we should do the switch as soon as we release 1.5.2

@HollowMan6 HollowMan6 marked this pull request as ready for review December 11, 2023 15:41
@HollowMan6 HollowMan6 changed the title Upgrade Android Component to 120.1.0 & AGP to 8.0.2 Upgrade Android Component to 121.0 & AGP to 8.0.2 Dec 31, 2023
@HollowMan6 HollowMan6 force-pushed the gecko-118.1.0 branch 2 times, most recently from 12eb1af to 4f5b7a5 Compare January 17, 2024 19:16
@HollowMan6 HollowMan6 changed the title Upgrade Android Component to 121.0 & AGP to 8.0.2 Upgrade Android Component to 121.1 & AGP to 8.2.0 Jan 17, 2024
@HollowMan6 HollowMan6 changed the title Upgrade Android Component to 121.1 & AGP to 8.2.0 Upgrade Android Component to 121.1.0 & AGP to 8.2.0 Jan 17, 2024
@HollowMan6
Upgrade Android Component version to 121.1.0
c8300cb 
Upgrade AGP to 8.2.1

Signed-off-by: Songlin Jiang <sjiang@igalia.com>
@HollowMan6 HollowMan6 changed the title Upgrade Android Component to 121.1.0 & AGP to 8.2.0 Upgrade Android Component to 121.1.0 & AGP to 8.2.1 Jan 21, 2024
svillar
svillar approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it!

Nice to see that the amount of changes gets smaller as we update more frequently

@svillar svillar merged commit 89f1df3 into main Jan 24, 2024
20 checks passed
@svillar svillar deleted the gecko-118.1.0 branch January 24, 2024 12:24
@HollowMan6 HollowMan6 mentioned this pull request Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javifernandez javifernandez javifernandez left review comments

@svillar svillar svillar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HollowMan6 @svillar @javifernandez