Fix widgets hovering in library UI when DPI is not 100 #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. The fix looks good to me but let's wait for more feedback before merging it. |
svillar
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Do not include the relanding of @felipeerias's patch, we'll use another PR for that.
I'm going to give it a go, but I'm concerned to have this code with an exception to an exception. My guts are telling me that something else is wrong and that we should handle it differently. In any case, on the event of problems we can always revert these two withouth much trouble so we should be safe.
HollowMan6
force-pushed
the
felipeerias/viewportMetrics
branch
from
dc054da
to
bbda638
Compare
Actually, although the code looks like we are making an exception to an exception, the only exception we have to make in fact is that, we don't need to divide the scale factor when we pass the motion event to gecko. I don't know if there's any other simple and good way to have this one but it's the way I can think of. |
The issue mentioned in #1106 is not caused by #1105, but rather #1086 (comment) This commit adds an exception to the library UI so that we make sure we are actually in the web page when we reset the scale to 1 for motion event handling. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
force-pushed
the
felipeerias/viewportMetrics
branch
from
bbda638
to
eb7151f
Compare
felipeerias
added a commit
that referenced
this pull request
Nov 21, 2023
Adjust the default DPI that we pass to the Web engine so that the texture for the default window will have twice the resolution. Adjust the default density so that the default window has a logical size of 1024x576 CSS pixels. Set the size of the maximum window so that its associated texture fits within 2560x2560, which is the maximum in some systems. The window scaling will interpolate between the default and maximum values. This commit needed to be reverted because it clashed with recent changes related to motion event handling. See: #1106 #1107
HollowMan6
added a commit
that referenced
this pull request
Nov 21, 2023
b92ea92 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
felipeerias
added a commit
that referenced
this pull request
Nov 21, 2023
Adjust the default DPI that we pass to the Web engine so that the texture for the default window will have twice the resolution. Adjust the default density so that the default window has a logical size of 1024x576 CSS pixels. Set the size of the maximum window so that its associated texture fits within 2560x2560, which is the maximum in some systems. The window scaling will interpolate between the default and maximum values. This commit needed to be reverted because it clashed with recent changes related to motion event handling. See: #1105 #1106 #1107
svillar
pushed a commit
that referenced
this pull request
Nov 21, 2023
Adjust the default DPI that we pass to the Web engine so that the texture for the default window will have twice the resolution. Adjust the default density so that the default window has a logical size of 1024x576 CSS pixels. Set the size of the maximum window so that its associated texture fits within 2560x2560, which is the maximum in some systems. The window scaling will interpolate between the default and maximum values. This commit needed to be reverted because it clashed with recent changes related to motion event handling. See: #1105 #1106 #1107
felipeerias
pushed a commit
that referenced
this pull request
Nov 21, 2023
b92ea92 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
added a commit
that referenced
this pull request
Nov 22, 2023
Related to our recent changes in #1107 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
added a commit
that referenced
this pull request
Nov 24, 2023
Related to our recent changes in #1107 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
svillar
pushed a commit
that referenced
this pull request
Nov 27, 2023
Related to our recent changes in #1107 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
felipeerias
pushed a commit
that referenced
this pull request
Nov 27, 2023
* Fix widgets hovering in library UI when DPI is not 100 The issue mentioned in #1106 is not caused by #1105, but rather #1086 (comment) This commit adds an exception to the library UI so that we make sure we are actually in the web page when we reset the scale to 1 for motion event handling. --------- Signed-off-by: Songlin Jiang <sjiang@igalia.com> Co-authored-by: Sergio Villar Senin <svillar@igalia.com>
felipeerias
added a commit
that referenced
this pull request
Nov 27, 2023
Adjust the default DPI that we pass to the Web engine so that the texture for the default window will have twice the resolution. Adjust the default density so that the default window has a logical size of 1024x576 CSS pixels. Set the size of the maximum window so that its associated texture fits within 2560x2560, which is the maximum in some systems. The window scaling will interpolate between the default and maximum values. This commit needed to be reverted because it clashed with recent changes related to motion event handling. See: #1105 #1106 #1107
felipeerias
pushed a commit
that referenced
this pull request
Nov 27, 2023
Related to our recent changes in #1107 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
felipeerias
pushed a commit
that referenced
this pull request
Dec 7, 2023
* Fix widgets hovering in library UI when DPI is not 100 The issue mentioned in #1106 is not caused by #1105, but rather #1086 (comment) This commit adds an exception to the library UI so that we make sure we are actually in the web page when we reset the scale to 1 for motion event handling. --------- Signed-off-by: Songlin Jiang <sjiang@igalia.com> Co-authored-by: Sergio Villar Senin <svillar@igalia.com>
felipeerias
added a commit
that referenced
this pull request
Dec 7, 2023
Adjust the default DPI that we pass to the Web engine so that the texture for the default window will have twice the resolution. Adjust the default density so that the default window has a logical size of 1024x576 CSS pixels. Set the size of the maximum window so that its associated texture fits within 2560x2560, which is the maximum in some systems. The window scaling will interpolate between the default and maximum values. This commit needed to be reverted because it clashed with recent changes related to motion event handling. See: #1105 #1106 #1107
felipeerias
pushed a commit
that referenced
this pull request
Dec 7, 2023
Related to our recent changes in #1107 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue mentioned in PR #1106 is not caused by #1105, but rather #1086 (comment)
This commit adds an exception to the library UI so that we make sure we are actually on the web page when we reset the scale to 1 for motion event handling.