Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop Mode overrides for popular Chinese websites #1116

Merged
merged 1 commit into from Nov 24, 2023

Conversation

felipeerias
Copy link
Contributor

@felipeerias felipeerias commented Nov 23, 2023

Add Desktop Mode overrides for these popular Chinese websites:

  • youku.com (layout too large, pushes to install the mobile app)
  • bilibili.com (requires the mobile app)
  • iqiyi.com (the layout has bugs, some icons are too large, etc.)
  • ixigua.com (video playback triggers a bug in Wolvic, the controllers disappear and can not be enabled again)
  • qq.com (layout too large, pushes to install the mobile app)
  • huya.com (mobile layout has bugs)

Add Desktop Mode overrides for these popular Chinese websites:

- youku.com
- bilibili.com
- iqiyi.com
- ixigua.com
- qq.com
- huya.com
Copy link
Collaborator

@HollowMan6 HollowMan6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, actually, the majority of popular Chinese websites will spam users on their mobile web pages to download their Apps for the sake of their spamming advertisements and making money. So I would say #1012 is the better approach so that at least Chinese users can have a cleaner browsing experience (I don't think it's a good way to have an exhaustive list of all Chinese websites here)

@felipeerias
Copy link
Contributor Author

More details about the issues that each page has in Mobile mode.

  • youku.com: layout too large, often pushes to install the app
  • bilibili.com: requires the app
  • iqiyi.com: the layout has bugs (icons too large, etc.)
  • ixigua.com: video playback triggers a bug in Wolvic (controllers disappear and can not be enabled again)
  • qq.com: layout too large, often pushes to install the app
  • huya.com: buggy layout

Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svillar svillar merged commit 81a451c into main Nov 24, 2023
18 checks passed
@svillar svillar deleted the felipeerias/chinaDesktopOverrides branch November 24, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants