Hide brightness button when playing video in Passthrough #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollowMan6
force-pushed
the
video-passthrough
branch
from
791cc29
to
0b4c7e9
Compare
svillar
requested changes
Nov 24, 2023
app/src/common/shared/com/igalia/wolvic/ui/widgets/menus/BrightnessMenuWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/menus/BrightnessMenuWidget.java
Outdated
Show resolved
Hide resolved
Yeah, that sounds good, maybe I should rework this PR |
Also move the brightness button to the middle (so that we don't need to rearrange the style to other buttons) Motivation: Those brightness settings don't work for passthrough environment Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
force-pushed
the
video-passthrough
branch
from
0b4c7e9
to
5440d16
Compare
HollowMan6
changed the title
|
Updated so that we just simply hide the brightness button when playing video in Passthrough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move the brightness button to the middle (so that we don't need to rearrange the style to other buttons)
Motivation:
Those brightness settings don't work for passthrough environment