Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two new environments for 1.5.2 #1135

Merged
merged 1 commit into from Dec 4, 2023
Merged

Conversation

felipeerias
Copy link
Contributor

Add the following environments for Wolvic 1.5.2:

  • Pretville Cinema (CC0)
  • Winter Night by Paul (CC-BY)

@felipeerias felipeerias changed the base branch from main to gh-pages December 3, 2023 17:39
@felipeerias
Copy link
Contributor Author

See Igalia/wolvic-3D-environments#5 for the environment files.

Copy link
Collaborator

@HollowMan6 HollowMan6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

props.json Outdated
Comment on lines 38 to 39
"thumbnail": "https://igalia.github.io/wolvic-test-environments/pretvillecinema/pretvillecinema.png",
"payload": "https://igalia.github.io/wolvic-test-environments/pretvillecinema/pretvillecinema.zip"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, should here be https://igalia.github.io/wolvic-3D-environments when Igalia/wolvic-3D-environments#5 is merged?

props.json Outdated
Comment on lines 44 to 45
"thumbnail": "https://igalia.github.io/wolvic-test-environments/winternight/winternight.png",
"payload": "https://igalia.github.io/wolvic-test-environments/winternight/winternight.zip"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please use the correct URLs

@felipeerias
Copy link
Contributor Author

@HollowMan6 @svillar Fixed.

@svillar svillar merged commit acd6433 into gh-pages Dec 4, 2023
@svillar svillar deleted the felipeerias/winterCinemaEnvs branch December 4, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants