[Lynx] Workaround in the GestureManager to detect system gestures #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
requested changes
Apr 30, 2024
|
I'd also suggest to change a bit the title to something like |
Since Lynx 1.1.8 we can realy on the R_FB_hand_tracking_aim OpenX Extension, so we can use the its specific Gesture Manager. It works fine for the getting poses and managing pinching gestures, but the XR_HAND_TRACKING_AIM_VALID_BIT_FB is not properly updated, so we can not use it to detect system gestures.
javifernandez
force-pushed
the
lynx-handtracking-extensions
branch
from
5e0219f
to
361db31
Compare
Umm, I think that the relation between that title and the code change isn't obvious. As a matter of fact, we were using the extension with upgrading the SO to the version 1.1.8. The PR is more about fixing a bug when using the extension. |
svillar
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Just a couple of comments:
- title "use handjoints gesture manager" is wrong, there is no such a thing (maybe just GestureManager?). Also wdyt about changing it to something like "[Lynx] Add workaround to use GestureManager to detect system gestures" or something like that
- Some typos:
- R_FB_hand_tracking_aim needs a
X - realy -> rely
- OpenX -> OpenXR
javifernandez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Lynx 1.1.8 we can really on the XR_FB_hand_tracking_aim OpenXR Extension, so we can use the its specific Gesture Manager. It works fine for the getting poses and managing pinching gestures, but the XR_HAND_TRACKING_AIM_SYSTEM_GESTURE_BIT_FB is not properly set, so we can not use it to detect system gestures. Hence, we need to rely on the GestureManager implementation based on the manual computation of the hand's position and orientation.
Additionally, the XR_HAND_TRACKING_AIM_VALID_BIT_FB is not being updated either, so we can't rely on it to be sure the hand gesture is actually meant to be a system gesture.
Fixes #1392