[Vision Glass] Voice button can be used for search and text input #1449
+68
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the implementation of each system functionality to a separate package, so it is easier to integrate them in other flavours.
Set up the connection to the Huawei Speech Recognition service. The voice button on the phone UI will perform a search if the user is not currently writing on a text field (and therefore the keyboard is not visible). When the keyboard is visible, the voice button will capture text which will be entered into the text field that the user is editing.
This was referenced Jun 26, 2024
svillar
approved these changes
Jun 26, 2024
| mSupportedLanguages = Collections.emptyList(); | ||
| } else { | ||
| mSupportedLanguages = speechRecognizer.getSupportedLanguages(); | ||
| } |
There was a problem hiding this comment.
as it's just an assignment I think we can just use the ternary operator and do it in one line
| @@ -503,6 +508,27 @@ private void updateDisplays() { | |||
| mViewModel.updateConnectionState(PhoneUIViewModel.ConnectionState.DISPLAY_UNAVAILABLE); | |||
| } | |||
|
|
|||
| private void initializeAGConnect() { | |||
| Log.e(LOGTAG, "initializeAGConnect"); | |||
There was a problem hiding this comment.
This is not needed, and not an error anyway.
| @@ -7,7 +7,6 @@ public abstract class PlatformActivityPlugin { | |||
| public interface PlatformActivityPluginListener { | |||
| void onPlatformScrollEvent(float distanceX, float distanceY); | |||
| } | |||
| abstract void onKeyboardVisibilityChange(boolean isVisible); | |||
There was a problem hiding this comment.
Nice that we can remove this, I've never really liked it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up the connection to the Huawei Speech Recognition service.
The voice button on the phone UI will perform a search if the user is not currently writing on a text field (and therefore the keyboard is not visible).
When the keyboard is visible, the voice button will capture text which will be entered into the text field that the user is editing.
This PR also fixes a couple of crashes when the voice recogniser could not be properly initialised.
It is a bit inconvenient that the implementation of this functionality is split between the
hvrandvisionglassflavours. Maybe this is something that we could improve in the future.