Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assert() on Mac compilation #722

Merged
merged 1 commit into from Jun 13, 2023
Merged

Fix assert() on Mac compilation #722

merged 1 commit into from Jun 13, 2023

Conversation

felipeerias
Copy link
Contributor

Compiling on Mac requires us to explicitly include the standard cassert header.

svillar
svillar requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this we should not use it. Mind replacing by <assert.h> which is already used in Wolvic?

@felipeerias
Fix assert() on Mac compilation
6d5b5cc 
Compiling on Mac requires us to explicitly include the standard assert.h header.
@felipeerias felipeerias requested a review from svillar June 13, 2023 08:14
@felipeerias
Copy link
Contributor Author

@svillar Thanks, updated.

@svillar svillar merged commit 4fa46e7 into main Jun 13, 2023
6 checks passed
@svillar svillar deleted the felipeerias/macAsserts branch June 13, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svillar svillar svillar approved these changes

@elima elima Awaiting requested review from elima

@javifernandez javifernandez Awaiting requested review from javifernandez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felipeerias @svillar