Add support for browser density #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2022
It's being called from 2 different places. Unifying the call in a single private method is less error prone and easier to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds support for using a different density to render a WSession. Historically we have been using 1.0 because GeckoSession handled it internally but as we integrate new backends there is a difference in sizes between the pixel size and the browser dpi/point size, leading to really small browser viewports with 1.0.
One complexity added with this change is that in the WindowWidget we relied on a surface size change caused by different densities between the UI and the browser to generate new Surfaces when switching between the Browser Display and the custom Library UI (bookmarks, history, etc) that are shown on the same quad. We need to force a new surface creation when using layers if the densities between both are equal.