Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with JDK 17 #773

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix build with JDK 17 #773

merged 1 commit into from
Jun 28, 2023

Conversation

HollowMan6
Copy link
Collaborator

Starting from Flamingo, the Android Studio IDE is bundled with JDK 17.

This PR fixes the build error Unable to make field private final java.lang.String java.io.File.path accessible: module java.base does not "opens java.io" to unnamed module I encountered when I tried to build it with JDK 17. I fixed it by referring to https://stackoverflow.com/a/69179997, and I found that only --add-opens=java.base/java.io=ALL-UNNAMED is needed here.

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6
Copy link
Collaborator Author

CI failed with Input required and not supplied: token and looks like it's not caused by this change. Not sure what's going on with the THIRD_PARTY_PAT secret https://github.com/Igalia/wolvic/blob/main/.github/workflows/ci.yml#L39

@svillar
Copy link
Member

svillar commented Jun 27, 2023

yeah exactly what I did in PR #752 while trying to fix some other issue

@svillar svillar closed this Jun 27, 2023
@svillar svillar reopened this Jun 27, 2023
@HollowMan6
Copy link
Collaborator Author

Oh Okay, sorry I didn’t check that it’s actually a duplication of a closed PR. Now I wonder why that PR #752 got unmerged while we still have build error for JDK17? @svillar

@svillar
Copy link
Member

svillar commented Jun 28, 2023

Oh Okay, sorry I didn’t check that it’s actually a duplication of a closed PR. Now I wonder why that PR #752 got unmerged while we still have build error for JDK17? @svillar

Oh no worries, it was just a comment, nobody expects contributors to check abandoned PRs 😄. It was not merged because I was trying to fix one issue with CI and I thought the Java version could be the culprit. As it was not fixing it I abandoned it. But yeah a valid fix anyway.

Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the patch!

@svillar svillar merged commit 398f3a6 into Igalia:main Jun 28, 2023
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants