Fix and Check warnings / deprecation notes in the current build #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
requested changes
Jul 4, 2023
app/src/common/shared/com/igalia/wolvic/addons/views/AddonOptionsPermissionsView.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/addons/views/AddonOptionsPermissionsView.java
Show resolved
Hide resolved
svillar
approved these changes
Jul 4, 2023
|
I just squashed those review fixes commmits
|
svillar
requested changes
Jul 5, 2023
app/src/common/gecko/com/igalia/wolvic/browser/api/impl/GeckoViewFetchClient.kt
Show resolved
Hide resolved
svillar
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Also as a general comment please do include the link to the issues you've created for the other dependency issues in the comments in the code. Instead of repeating "this is deprecated since..." we could better simply add "See URL_TO_THE_ISSUE". The comments will be shorter as the detailed explanation is in the issue, and we'll have traceability.
Signed-off-by: Songlin Jiang <sjiang@igalia.com>
PackagingOptions.jniLibs.useLegacyPackaging should be set to true because android:extractNativeLibs is set to "true" in AndroidManifest.xml. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
- w: wolvic/app/src/common/gecko/com/igalia/wolvic/browser/api/impl/GeckoViewFetchClient.kt:26:5 Parameter 'context' is never used - w: wolvic/app/src/common/gecko/com/igalia/wolvic/browser/api/impl/GeckoWebExtension.kt:272:29 Unnecessary safe call on a non-null receiver of type WebExtension.MetaData - w: wolvic/app/src/common/shared/com/igalia/wolvic/browser/adapter/ComponentsAdapter.kt:88:15 This declaration needs opt-in. Its usage should be marked with '@kotlinx.coroutines.ExperimentalCoroutinesApi' or '@OptIn(kotlinx.coroutines.ExperimentalCoroutinesApi::class)' Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Signed-off-by: Songlin Jiang <sjiang@igalia.com>
|
Done! Ready to get merged again. |
Fix #810 Gecko has deprecated cookieLifetime as "this feature is not available anymore" since v103, and we are now using v103 https://github.com/Igalia/gecko-dev/tree/FIREFOX_103_0_2_RELEASE cookieLifetime can be safely removed. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are also some warnings that may be fixed by upgrading the dependency versions, and they are not fixed in this PR:
> Task :app:compressAospArm64GeckoGenericDebugAssets warn: removing resource com.igalia.wolvic:string/mozac_browser_errorpages_page_go_back without required default value. warn: removing resource com.igalia.wolvic:string/mozac_browser_errorpages_page_title without required default value. warn: removing resource com.igalia.wolvic:string/mozac_feature_addons_user_rating_count without required default value.> Task :app:stripAospArm64GeckoGenericDebugDebugSymbols Unable to strip the following libraries, packaging them as they are: libjnidispatch.so.WARNING: Since I still haven't got my testing device, the code in bundled JDK 17 using Android Studio Flamingo.