Fix deprecated android.inputmethodservice.Keyboard and keyboardView #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now fixed |
HollowMan6
force-pushed
the
keyboardview
branch
3 times, most recently
from
f5da67d
to
b47e894
Compare
There was a problem hiding this comment.
The change looks good and it seems it works fine at least in Quest2 and Lynx R1.
However, I'd like to investigate #845 before landing, at least to understand its root case and that this change wouldn't make the problem bigger.
As instructed: This class is deprecated because this is just a convenient UI widget class that
application developers can re-implement on top of existing public APIs. If you have
already depended on this class, consider copying the implementation from AOSP into
your project or re-implementing a similar widget by yourselves
Signed-off-by: Songlin Jiang <sjiang@igalia.com>
svillar
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As instructed: https://developer.android.com/reference/android/inputmethodservice/KeyboardView
This class is deprecated because this is just a convenient UI widget class that application developers can re-implement on top of existing public APIs. If you have already depended on this class, consider copying the implementation from AOSP into your project or re-implementing a similar widget by yourselves.