Wait until Privacy Policy has been accepted #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not initialize remote services like analytics and push messages until the Privacy Policy has been accepted. Whit PR waits until the user has accepted Wolvic's Privacy Policy before starting those services.
elima
approved these changes
Jul 11, 2023
| @@ -275,6 +261,29 @@ private void initializeAGConnect() { | |||
| } | |||
| } | |||
|
|
|||
| private void enablePrivacySensitiveServices() { | |||
| Log.d(TAG, "Privacy policy is accepted, initializing services"); | |||
There was a problem hiding this comment.
Nitpick: I would move this log string outside this method, and put it e.g, right above the place when the method is called, inside the if statement where you check isPrivacyPolicyAccepted().
| @@ -275,6 +261,29 @@ private void initializeAGConnect() { | |||
| } | |||
| } | |||
|
|
|||
| private void enablePrivacySensitiveServices() { | |||
| Log.d(TAG, "Privacy policy is accepted, initializing services"); | |||
| HiAnalyticsInstance instance = HiAnalytics.getInstance(getApplicationContext()); | |||
There was a problem hiding this comment.
Another nit: Maybe add back the Enable analytics comment above this block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not initialize remote services like analytics and push messages until the Privacy Policy has been accepted.
Whit PR waits until the user has accepted Wolvic's Privacy Policy before starting those services.