Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the "mainlandChina" store flavour #836

Merged
merged 1 commit into from Jul 12, 2023

Conversation

felipeerias
Copy link
Contributor

@felipeerias felipeerias commented Jul 12, 2023

This PR defines the "mainlandChina" store flavour, which includes a specific phone UI.

Copy link
Member

@javifernandez javifernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@felipeerias felipeerias merged commit 22c6c25 into main Jul 12, 2023
7 checks passed
@felipeerias felipeerias deleted the felipeerias/mainlandChinaFlavour branch July 12, 2023 15:58
@svillar
Copy link
Member

svillar commented Jul 12, 2023

@felipeerias @javifernandez Why?

We already have AppInChina for that

@javifernandez
Copy link
Member

@felipeerias @javifernandez Why?

We already have AppInChina for that

We didn't want to use the "AppInChina" name as part of the Wolvic code; not a special reason, but we thought something more generic was more appropriated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants