New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid collecting Wifi related data without user consent #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should ensure the user accepted the 'terms of service' and the 'privacy policy' agreements before collecting data during the wifi connection process.
javifernandez
force-pushed
the
handle-wifi-data
branch
from
July 13, 2023 12:20
9772643
to
8f2fb12
Compare
felipeerias
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
felipeerias
pushed a commit
that referenced
this pull request
Jul 13, 2023
We should ensure the user accepted the 'terms of service' and the 'privacy policy' agreements before collecting data during the wifi connection process.
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
We should ensure the user accepted the 'terms of service' and the 'privacy policy' agreements before collecting data during the wifi connection process.
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
We should ensure the user accepted the 'terms of service' and the 'privacy policy' agreements before collecting data during the wifi connection process.
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
We should ensure the user accepted the 'terms of service' and the 'privacy policy' agreements before collecting data during the wifi connection process.
felipeerias
pushed a commit
that referenced
this pull request
Aug 6, 2023
…nt (#840) We should ensure the user accepted the 'terms of service' and the 'privacy policy' agreements before collecting data during the wifi connection process.
felipeerias
pushed a commit
that referenced
this pull request
Aug 6, 2023
…nt (#840) We should ensure the user accepted the 'terms of service' and the 'privacy policy' agreements before collecting data during the wifi connection process.
felipeerias
pushed a commit
that referenced
this pull request
Aug 7, 2023
…nt (#840) We should ensure the user accepted the 'terms of service' and the 'privacy policy' agreements before collecting data during the wifi connection process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should ensure the user accepted the 'terms of service' and the 'privacy policy' agreements before collecting data during the wifi connection process.