[OpenXR] Add support for XR_EXTX_overlay extension #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elima
approved these changes
Jul 25, 2023
| @@ -1435,6 +1444,14 @@ DeviceDelegateOpenXR::EnterVR(const crow::BrowserEGLContext& aEGLContext) { | |||
| XrSessionCreateInfo createInfo{XR_TYPE_SESSION_CREATE_INFO}; | |||
| createInfo.next = reinterpret_cast<const XrBaseInStructure*>(&m.graphicsBinding); | |||
| createInfo.systemId = m.system; | |||
|
|
|||
| if (OpenXRExtensions::IsExtensionSupported(XR_EXTX_OVERLAY_EXTENSION_NAME)) { | |||
| XrSessionCreateInfoOverlayEXTX overlayInfo { .type = XR_TYPE_SESSION_CREATE_INFO_OVERLAY_EXTX, .createFlags = 0, .sessionLayersPlacement = 0 }; | |||
There was a problem hiding this comment.
Nit: I would break this long line into several lines, one for each member. It helps read-ability IMO.
This provisional extension allows multiple OpenXR apps to run concurrently and get their contents composited. Apps specify at which level they'd like to be composited from 0 (first to be composited) to MAX_UINT32 (last to be composited on top of all the other ones). We initially selected 0 so that all the other OpenXR apps supporting this extension will render on top (unless one uses also 0 and is launched before Wolvic). From the list of currently supported devices Pico 4 & 4E, Lynx-R1 and Lenovo A3 devices support this extension.
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
This provisional extension allows multiple OpenXR apps to run concurrently and get their contents composited. Apps specify at which level they'd like to be composited from 0 (first to be composited) to MAX_UINT32 (last to be composited on top of all the other ones). We initially selected 0 so that all the other OpenXR apps supporting this extension will render on top (unless one uses also 0 and is launched before Wolvic). From the list of currently supported devices Pico 4 & 4E, Lynx-R1 and Lenovo A3 devices support this extension.
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
This provisional extension allows multiple OpenXR apps to run concurrently and get their contents composited. Apps specify at which level they'd like to be composited from 0 (first to be composited) to MAX_UINT32 (last to be composited on top of all the other ones). We initially selected 0 so that all the other OpenXR apps supporting this extension will render on top (unless one uses also 0 and is launched before Wolvic). From the list of currently supported devices Pico 4 & 4E, Lynx-R1 and Lenovo A3 devices support this extension.
felipeerias
pushed a commit
that referenced
this pull request
Aug 4, 2023
This provisional extension allows multiple OpenXR apps to run concurrently and get their contents composited. Apps specify at which level they'd like to be composited from 0 (first to be composited) to MAX_UINT32 (last to be composited on top of all the other ones). We initially selected 0 so that all the other OpenXR apps supporting this extension will render on top (unless one uses also 0 and is launched before Wolvic). From the list of currently supported devices Pico 4 & 4E, Lynx-R1 and Lenovo A3 devices support this extension.
felipeerias
pushed a commit
that referenced
this pull request
Aug 6, 2023
) This provisional extension allows multiple OpenXR apps to run concurrently and get their contents composited. Apps specify at which level they'd like to be composited from 0 (first to be composited) to MAX_UINT32 (last to be composited on top of all the other ones). We initially selected 0 so that all the other OpenXR apps supporting this extension will render on top (unless one uses also 0 and is launched before Wolvic). From the list of currently supported devices Pico 4 & 4E, Lynx-R1 and Lenovo A3 devices support this extension.
felipeerias
pushed a commit
that referenced
this pull request
Aug 6, 2023
) This provisional extension allows multiple OpenXR apps to run concurrently and get their contents composited. Apps specify at which level they'd like to be composited from 0 (first to be composited) to MAX_UINT32 (last to be composited on top of all the other ones). We initially selected 0 so that all the other OpenXR apps supporting this extension will render on top (unless one uses also 0 and is launched before Wolvic). From the list of currently supported devices Pico 4 & 4E, Lynx-R1 and Lenovo A3 devices support this extension.
felipeerias
pushed a commit
that referenced
this pull request
Aug 7, 2023
) This provisional extension allows multiple OpenXR apps to run concurrently and get their contents composited. Apps specify at which level they'd like to be composited from 0 (first to be composited) to MAX_UINT32 (last to be composited on top of all the other ones). We initially selected 0 so that all the other OpenXR apps supporting this extension will render on top (unless one uses also 0 and is launched before Wolvic). From the list of currently supported devices Pico 4 & 4E, Lynx-R1 and Lenovo A3 devices support this extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provisional extension allows multiple OpenXR apps to run concurrently
and get their contents composited. Apps specify at which level they'd like
to be composited from 0 (first to be composited) to MAX_UINT32 (last to be
composited on top of all the other ones). We initially selected 0 so that all
the other OpenXR apps supporting this extension will render on top
(unless one uses also 0 and is launched before Wolvic).
From the list of currently supported devices Pico 4 & 4E, Lynx-R1 and
Lenovo A3 devices support this extension.