Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta store fixes #876

Merged
merged 2 commits into from Jul 29, 2023
Merged

Meta store fixes #876

merged 2 commits into from Jul 29, 2023

Conversation

svillar
Copy link
Member

@svillar svillar commented Jul 28, 2023

This fixes a couple of issues with meta packages

  • Limit target sdk to v32 (the maximum allowed by the store)
  • Do not request ACCESS_BACKGROUND_LOCATION (not allowed by the store)

@svillar
Target API 32 for Meta (OculusVR)
3bd2039 
Meta store still requires packages to target API v32
@svillar
Do not request ACCESS_BACKGROUND_LOCATION for meta
98470de 
The meta store does not allow packages to ask for that permission
HollowMan6
HollowMan6 approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@HollowMan6 HollowMan6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svillar svillar merged commit aca5227 into main Jul 29, 2023
7 checks passed
@svillar svillar deleted the meta-store-fixes branch July 29, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HollowMan6 HollowMan6 HollowMan6 approved these changes

@felipeerias felipeerias Awaiting requested review from felipeerias

@javifernandez javifernandez Awaiting requested review from javifernandez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svillar @HollowMan6