Continue upgrading some deprecated methods #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollowMan6
force-pushed
the
CONNECTIVITY_ACTION
branch
4 times, most recently
from
c2a6ce1
to
18066c1
Compare
svillar
requested changes
Aug 7, 2023
app/src/common/shared/com/igalia/wolvic/utils/ConnectivityReceiver.java
Outdated
Show resolved
Hide resolved
HollowMan6
force-pushed
the
CONNECTIVITY_ACTION
branch
from
18066c1
to
94f95c1
Compare
svillar
requested changes
Aug 14, 2023
app/src/common/shared/com/igalia/wolvic/utils/ConnectivityReceiver.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/utils/ConnectivityReceiver.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/utils/ConnectivityReceiver.java
Outdated
Show resolved
Hide resolved
Since our min API is 24 currently Signed-off-by: Songlin Jiang <sjiang@igalia.com>
This is deprecated in API level 30. https://developer.android.com/reference/android/view/View.OnSystemUiVisibilityChangeListener Solution referred to flutter/engine#30931 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Have FragmentHostCallback implement androidx.core.content.OnConfigurationChangedProvider to automatically dispatch configuration changes to fragments Resolves #822 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
AsyncTask class was deprecated in API level 30. Use the standard java.util.concurrent to replace it. Resolves #801 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
WifiInfo.getConnectionInfo() was deprecated in API level 31. Starting with Build.VERSION_CODES#S, WifiInfo retrieval is moved to ConnectivityManager API surface. WifiInfo is attached in NetworkCapabilities#getTransportInfo() which is available via callback in NetworkCallback#onCapabilitiesChanged(Network, NetworkCapabilities) or on-demand from ConnectivityManager#getNetworkCapabilities(Network). Refer to https://stackoverflow.com/a/73504558 Resolves #802 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
force-pushed
the
CONNECTIVITY_ACTION
branch
from
94f95c1
to
96cccde
Compare
|
I have moved the original first commit into a separate PR: #906 That commit should be correct, as I have tested it. Wolvic can correctly tell the user that the network has disconnected or reconnected with that change. |
svillar
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #822
Resolves #801
Resolves #802