Fix restarting Wolvic #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollowMan6
requested review from
svillar,
elima,
felipeerias and
javifernandez
svillar
requested changes
Sep 5, 2023
app/src/common/shared/com/igalia/wolvic/ui/widgets/dialogs/RestartDialogWidget.java
Show resolved
Hide resolved
Resolves #949 Based on the answer from https://stackoverflow.com/a/71392776 This works with Android > 10, tested up to Android 13 (preview). Someone said that they also tested in Android 7 and it works well. Since Android 10, you can't launch from the background, so the old method is no longer working: https://developer.android.com/guide/components/activities/background-starts The new one no longer needs to schedule a start from the background, so just remove the scheduled way of restarting. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
force-pushed
the
fix-restart
branch
from
f4f8fef
to
d863cf9
Compare
svillar
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #949
Based on the answer from https://stackoverflow.com/a/71392776
This works with Android > 10, tested up to Android 13 (preview).
Someone said that they also tested in Android 7 and it works well.
Since Android 10, you can't launch from the background, so the old method is no longer working:
https://developer.android.com/guide/components/activities/background-starts
The new one no longer needs to schedule a start from the background, so just remove the scheduled way of restarting.