Allow open new page without interrupting video playing #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollowMan6
force-pushed
the
feedback-window
branch
from
5d670e7
to
6eef40a
Compare
HollowMan6
force-pushed
the
feedback-window
branch
from
6eef40a
to
b6b097d
Compare
svillar
requested changes
Sep 6, 2023
If there's no video playing in the current window, we still open the new page in a new tab. If we have video playing in current window, ensure we don't open a new tab in a window that has active video, but open it in the Window that has no video playing. If all the current opened Windows have video playing, we have to open uri in a new window. If we have maximum window number, then open the uri as a new tab in current window. Continue addressing #940 Related to #958 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
force-pushed
the
feedback-window
branch
from
b6b097d
to
ae13834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue addressing #940
Related to #958
If there's no video playing in the current window, we still open the new page in a new tab.
If we have video playing in current window, ensure we don't open a new tab in a window that has active video, but open it in the Window that has no video playing.
If all the current opened Windows have video playing, we have to open uri in a new window. If we have maximum window number, then open the uri as a new tab in current window.