Remove Find In Page Item when in kiosk mode #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the address bar is hidden in kiosk mode, we shouldn't have find in page then. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
requested review from
felipeerias,
svillar,
elima and
javifernandez
svillar
approved these changes
Sep 15, 2023
HollowMan6
added a commit
that referenced
this pull request
Sep 15, 2023
Now we show/hide the bar just for find in page Continue address #974 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
svillar
pushed a commit
that referenced
this pull request
Sep 18, 2023
Now we show/hide the bar just for find in page Continue address #974 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
felipeerias
pushed a commit
that referenced
this pull request
Sep 18, 2023
Now we show/hide the bar just for find in page Continue address #974 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the address bar is hidden in kiosk mode, we
shouldn't have find in page then.