Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel find in page on navigation #997

Merged
merged 1 commit into from Sep 21, 2023
Merged

Conversation

felipeerias
Copy link
Contributor

When the user clicks on a link on the page, we cancel the ongoing Find in Page.

When the user clicks on a link on the page, we cancel the
ongoing Find in Page.
Copy link
Collaborator

@HollowMan6 HollowMan6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Forgot about that)

Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@svillar svillar merged commit 907fe04 into main Sep 21, 2023
7 checks passed
@svillar svillar deleted the felipeerias/cancelFindOnNavigation branch September 21, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants