Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igUploader send multiple files in one request feature #1521

Merged
merged 11 commits into from
Jan 18, 2018

Conversation

DDavidkov
Copy link
Contributor

Closes #1501

Implement the igUploader "Multiple files upload in a single XHR"

$(".selector").igUpload("option", "sendDataInOneRequest", true);
```
*/
sendDataInOneRequest: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should name it singleRequest or useSingleRequest? @SlavUI What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for "singleRequest".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for useSingleRequest as it implies what value is expected.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it useSingleRequest :)


self._trigger(self.events.onFormDataSubmit,
null,
{ formData: formData,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 84.452% when pulling 7948c63 on DDavidkov/igUploadMultiple into eec36f2 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 84.452% when pulling 7948c63 on DDavidkov/igUploadMultiple into eec36f2 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 84.456% when pulling 8d06569 on DDavidkov/igUploadMultiple into 1db780e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 84.449% when pulling f664c1a on DDavidkov/igUploadMultiple into 7a1690a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 84.316% when pulling 99440e5 on DDavidkov/igUploadMultiple into 7a1690a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 84.313% when pulling a5a9be0 on DDavidkov/igUploadMultiple into 7a1690a on master.

@kdinev
Copy link
Member

kdinev commented Jan 15, 2018

@DDavidkov Convert the spaces into tabs for the whole file please.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 84.317% when pulling 14a54b6 on DDavidkov/igUploadMultiple into 3c4dfca on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 84.313% when pulling 98476dd on DDavidkov/igUploadMultiple into 3c4dfca on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 84.301% when pulling 778fb3f on DDavidkov/igUploadMultiple into 3c4dfca on master.

@kdinev kdinev merged commit b24714b into master Jan 18, 2018
@kdinev kdinev deleted the DDavidkov/igUploadMultiple branch January 18, 2018 08:29
@gedinakova
Copy link
Contributor

Related #1532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants