Add Row Editing Styling samples #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wnvko
previously approved these changes
Jul 2, 2019
ViktorSlavov
force-pushed
the
vslavov/row-edit-style
branch
from
53b67b2
to
9287644
Compare
ViktorSlavov
added
grid
hierarchical-grid
tree-grid
status: awaiting-test
and removed
status: in-development
labels
IvayloG
reviewed
Jul 12, 2019
src/app/grid/grid-row-editing-style/grid-row-editing-style.component.html
Outdated
Show resolved
Hide resolved
IvayloG
requested changes
Jul 12, 2019
There was a problem hiding this comment.
It seems a bit off that editing "UnitsInStock" for the igxGrid sample is not updating the Changes count. The same applies for editing the date fields in all samples (only when updating the input directly). Maybe we should further investigate if this is actually a bug in the product.
src/app/tree-grid/tree-grid-row-edit-style/tree-grid-row-edit-style.component.html
Outdated
Show resolved
Hide resolved
src/app/tree-grid/tree-grid-row-edit-style/tree-grid-row-edit-style.component.html
Show resolved
Hide resolved
# Conflicts: # src/app/grid/grid-routes-data.ts # src/app/hierarchical-grid/hierarchical-grid-routes-data.ts
IvayloG
previously approved these changes
Jul 16, 2019
|
Tested with the tree-grid row edit template fix: IgniteUI/igniteui-angular#5436 |
…-edit-style # Conflicts: # src/app/hierarchical-grid/hierarchical-grid-routes-data.ts
Lipata
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to IgniteUI/igniteui-angular#5436