Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grid): cond row selection fix for deselect all #2903

Merged
merged 5 commits into from Apr 4, 2022
Merged

fix(grid): cond row selection fix for deselect all #2903

merged 5 commits into from Apr 4, 2022

Conversation

kdinev
Copy link
Member

@kdinev kdinev commented Dec 6, 2021

@kdinev kdinev requested a review from IvayloG December 6, 2021 12:30
@IvayloG
Copy link
Contributor

IvayloG commented Apr 4, 2022

Sample works prior to merging to vNext

IvayloG
IvayloG requested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@IvayloG IvayloG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for the merge to vNext and the new package-lock

@IvayloG IvayloG self-requested a review April 4, 2022 09:00
IvayloG
IvayloG requested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@IvayloG IvayloG left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same fix should be done and will work (tested with latest vNext) for the hgrid and tgrid samples as well:

  • hierarchical-grid-conditional-row-selectors.component.ts
  • tree-grid-conditional-row-selectors.component.ts

@kdinev
Copy link
Member Author

kdinev commented Apr 4, 2022 •
edited

The same fix should be done and will work (tested with latest vNext) for the hgrid and tgrid samples as well:

  • hierarchical-grid-conditional-row-selectors.component.ts
  • tree-grid-conditional-row-selectors.component.ts

@IvayloG Done!

@zdrawku zdrawku merged commit 7646f59 into vNext Apr 4, 2022
@zdrawku zdrawku deleted the cond-row-selection-10689 branch April 4, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvayloG IvayloG IvayloG approved these changes

Assignees
No one assigned
Labels
row-selection status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdinev @IvayloG @zdrawku