Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): Fix horizontal sample orientation. #2987

Merged
merged 5 commits into from Apr 8, 2022
Merged

Conversation

MayaKirova
Copy link
Contributor

Closes #2985

@3phase
Copy link
Contributor

3phase commented Mar 31, 2022

The z-index of the focused item is getting bigger than their sibling, so the following happens:

image

I think that we should either change the z-index to 2, or investigate what causes the wider spanning item.

Besides that all looks well 😊

@MayaKirova
Copy link
Contributor Author

MayaKirova commented Apr 1, 2022

@3phase Content seems to overflow the 220px set for the item when active. Size should be fixed to 220px for all items now.

@dkamburov dkamburov merged commit 94d4618 into vNext Apr 8, 2022
@dkamburov dkamburov deleted the mkirova/fix-2985 branch April 8, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants