Fix for bug 247937 #242
Merged
Fix for bug 247937 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpavlinov
suggested changes
Jan 18, 2018
src/igcontrolbase/igcontrolbase.ts
Outdated
| @@ -230,6 +230,9 @@ export class IgControlBase<Model> implements DoCheck { | |||
| if (o1 === o2) { return true; } | |||
| if (o1 === null || o2 === null) { return false; } | |||
| if (o1 !== o1 && o2 !== o2) { return true; }// NaN === NaN | |||
| if (o1.nodeName) { | |||
There was a problem hiding this comment.
@tbelcheva The fix is ok, however there might be a case where the customer object has "nodeName" property and in this case the equalsDiff will not work. Please add some more conditions in order to make sure that this is indeed a DOM node. Here is some suggestion: https://stackoverflow.com/questions/384286/javascript-isdom-how-do-you-check-if-a-javascript-object-is-a-dom-object
MayaKirova
requested changes
Jan 18, 2018
MayaKirova
requested changes
Jan 22, 2018
tests/unit/iggrid/grid.spec.ts
Outdated
| } | ||
| }); | ||
| TestBed.compileComponents().then(() => { | ||
| debugger; |
There was a problem hiding this comment.
Please remove the debugger.
mpavlinov
suggested changes
Jan 22, 2018
src/igcontrolbase/igcontrolbase.ts
Outdated
| @@ -230,6 +230,13 @@ export class IgControlBase<Model> implements DoCheck { | |||
| if (o1 === o2) { return true; } | |||
| if (o1 === null || o2 === null) { return false; } | |||
| if (o1 !== o1 && o2 !== o2) { return true; }// NaN === NaN | |||
| var isDOMnode = typeof Node === "object" ? o1 instanceof Node : | |||
There was a problem hiding this comment.
@tbelcheva Please put all the code in a separate function(s) and also add tests for them.
MayaKirova
approved these changes
Jan 24, 2018
mpavlinov
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.