Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated properties for column pinning and hiding #10297

Merged
merged 9 commits into from Oct 18, 2021
Merged

Remove deprecated properties for column pinning and hiding #10297

merged 9 commits into from Oct 18, 2021

Conversation

mddragnev
Copy link
Member

Remove deprecated properties for hiding and pinning. Add toolbar actions input for button text.

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@mddragnev
Copy link
Member Author

Note: https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/column-hiding#toolbars-column-hiding-ui In this topic hiddenColumnsText property should be removed

dkamburov
dkamburov reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@dkamburov dkamburov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more deprecated properties in grid-base.directive.ts. Shouldn't they also be removed?

@mddragnev
Copy link
Member Author

mddragnev commented Oct 15, 2021 •
edited

There are some more deprecated properties in grid-base.directive.ts. Shouldn't they also be removed?

@dkamburov
We do not own the paging and exporting features that is why I haven`t removed them

@ChronosSF ChronosSF added ❌ status: awaiting-test PRs awaiting manual verification grid: column-hiding grid: column-pinning version: 13.0.x 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 18, 2021
@ChronosSF ChronosSF added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 18, 2021
@ChronosSF ChronosSF merged commit a5574f8 into master Oct 18, 2021
@ChronosSF ChronosSF deleted the mdragnev/grinders-deprecations branch October 18, 2021 14:22
@jackofdiamond5 jackofdiamond5 mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkamburov dkamburov dkamburov approved these changes

@ChronosSF ChronosSF ChronosSF approved these changes

@hanastasov hanastasov hanastasov approved these changes

Assignees

@dkamburov dkamburov

@ChronosSF ChronosSF

Labels
grid: column-hiding grid: column-pinning version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mddragnev @dkamburov @ChronosSF @hanastasov @kdinev