Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): fix scrolling issue #10718

Merged
merged 4 commits into from Dec 15, 2021
Merged

fix(tabs): fix scrolling issue #10718

merged 4 commits into from Dec 15, 2021

Conversation

zhosti
Copy link
Contributor

@zhosti zhosti commented Dec 10, 2021

Closes #10685
Closes #10676

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@zhosti zhosti added ❌ status: awaiting-test PRs awaiting manual verification tabs version: 13.0.x labels Dec 10, 2021
DiyanDimitrov
DiyanDimitrov previously approved these changes Dec 14, 2021
View reviewed changes
@viktorkombov viktorkombov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Dec 14, 2021
@viktorkombov viktorkombov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 💥 status: in-test PRs currently being tested labels Dec 15, 2021
@kdinev kdinev added ✅ status: verified Applies to PRs that have passed manual verification and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Dec 15, 2021
@kdinev kdinev merged commit 6f1d0af into 13.0.x Dec 15, 2021
@kdinev kdinev deleted the izhostov/fix-tab-scroll-13.0.x branch December 15, 2021 15:49
@renovate renovate bot mentioned this pull request Dec 21, 2021
Merged
1 task
This was referenced Feb 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

@onlyexeption onlyexeption Awaiting requested review from onlyexeption

Assignees

@viktorkombov viktorkombov

Labels
tabs version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zhosti @DiyanDimitrov @kdinev @viktorkombov @gedinakova