Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(igxGrid): Execute column notifyOnChanges after move on next detec… #11179

Merged
merged 9 commits into from Mar 15, 2022

Conversation

MayaKirova
Copy link
Contributor

@MayaKirova MayaKirova commented Mar 7, 2022

…tion cycle because if template has ngIf it will also trigger column collection change on template re-evaluation.

Closes #11116

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

…tion cycle because if template has ngIf it will also trigger column collection change on template re-evaluation.
@MayaKirova MayaKirova marked this pull request as ready for review March 10, 2022 14:52
@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification grid: column-moving labels Mar 10, 2022
@3phase 3phase added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 11, 2022
@3phase 3phase added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Mar 11, 2022
@dkamburov dkamburov changed the base branch from master to 13.1.x March 15, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: column-moving ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When moving a templated column in grid it does not stay in its new position.
3 participants