Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cd): resolving an issue with typedoc erros being swallowed - 13.1 #11380

Merged
merged 6 commits into from Apr 20, 2022

Conversation

ChronosSF
Copy link
Member

@ChronosSF ChronosSF commented Apr 12, 2022

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@kdinev
Copy link
Member

kdinev commented Apr 19, 2022

@ChronosSF Could you please push a commit, which causes the build to fail, and then revert it? Just so I can see that the change does what it's supposed to!

@kdinev kdinev added the typedoc label Apr 19, 2022
@ChronosSF
Copy link
Member Author

@ChronosSF Could you please push a commit, which causes the build to fail, and then revert it? Just so I can see that the change does what it's supposed to!

Sure, forgot you added the typedoc build to the CI . I tested it locally by checking the $LASTEXITCODE in powershell after running npm run build:typedoc:en:staging .

But let's see if the build will agree :)

@ChronosSF ChronosSF added the squash-merge Merge PR with "Squash and Merge" option label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧱 ci: build CI build related issues and PRs squash-merge Merge PR with "Squash and Merge" option typedoc version: 13.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants