Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simple-combo): Toggle combo on templated icon click - 14.2.x #12350

Merged
merged 3 commits into from Nov 24, 2022
Merged

fix(simple-combo): Toggle combo on templated icon click - 14.2.x #12350

merged 3 commits into from Nov 24, 2022

Conversation

ddaribo
Copy link
Contributor

@ddaribo ddaribo commented Nov 21, 2022

Closes #12322

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddaribo ddaribo linked an issue Nov 21, 2022 that may be closed by this pull request
Templeted toggle icon does not open/close the combo #12322
Closed
@ddaribo ddaribo added the ❌ status: awaiting-test PRs awaiting manual verification label Nov 22, 2022
@ddaribo ddaribo requested a review from wnvko November 23, 2022 09:56
@IvanKitanov17 IvanKitanov17 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 23, 2022
@teodosiah teodosiah merged commit ea9fd05 into 14.2.x Nov 24, 2022
@teodosiah teodosiah deleted the bpachilova/fix-12322-14.2.x branch November 24, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnvko wnvko wnvko approved these changes

Assignees

@IvanKitanov17 IvanKitanov17

Labels
simple-combo version: 14.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Templeted toggle icon does not open/close the combo
4 participants
@ddaribo @wnvko @teodosiah @IvanKitanov17