Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IgxInputDirective): Calculate required value when input is bound via formControl #12906

Merged
merged 2 commits into from Apr 25, 2023

Conversation

teodosiah
Copy link
Contributor

Closes #12895

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@teodosiah teodosiah added 🛠️ status: in-development Issues and PRs with active development on them input-group version: 15.1.x ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 21, 2023
@teodosiah teodosiah requested a review from Lipata April 21, 2023 08:15
Copy link
Member

@jackofdiamond5 jackofdiamond5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny how the native validation passes when you blur the required textarea but fails for the required input. I managed to get the textarea to become invalid after deleting its value but imo it should become invalid on blur as well, the same way the input does, though that's not really in our control I guess. Reading the spec on textarea and input shows some differences but nothing explaining why this works the way it does. Oh well.

@ddaribo ddaribo added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Apr 25, 2023
@teodosiah teodosiah merged commit 6dee405 into 15.1.x Apr 25, 2023
4 checks passed
@teodosiah teodosiah deleted the thristodorova/fix-12895-15.1.x branch April 25, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
input-group version: 15.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants