Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-picker): move the colors for special dates on the proper element #13014

Merged
merged 5 commits into from May 16, 2023
Merged

fix(date-picker): move the colors for special dates on the proper element #13014

merged 5 commits into from May 16, 2023

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented May 15, 2023 •
edited

Closes #12980

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

simeonoff
simeonoff previously approved these changes May 15, 2023
View reviewed changes
@simeonoff simeonoff linked an issue May 15, 2023 that may be closed by this pull request
[IgxDatePicker]: specialDates styles are not applied properly #12980
Closed
@simeonoff simeonoff changed the title style(date-picker) Move the colors for special dates on the proper element fix(date-picker): move the colors for special dates on the proper element May 15, 2023
simeonoff and others added 2 commits May 15, 2023 15:19
@simeonoff
Merge branch '14.2.x' into mpopov/special-date_#12980_14.2.x
e61f5f0
@desig9stein
style(date-picker) remove the color overrides from the date picker si…
4e2f845 
…nce they are unnecessary because the date picker inherits those colors from the calendar.
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels May 15, 2023
@simeonoff simeonoff merged commit 1d7d031 into 14.2.x May 16, 2023
4 checks passed
@simeonoff simeonoff deleted the mpopov/special-date_#12980_14.2.x branch May 16, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees

@RivaIvanova RivaIvanova

Labels
📅 date-picker version: 14.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IgxDatePicker]: specialDates styles are not applied properly
3 participants
@desig9stein @simeonoff @RivaIvanova