Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rating): update rating theme to consume schema colors #13541

Merged
merged 7 commits into from Oct 24, 2023

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Oct 10, 2023

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein desig9stein added ❌ status: awaiting-test PRs awaiting manual verification rating labels Oct 10, 2023
@SisIvanova SisIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 11, 2023
SisIvanova
SisIvanova previously approved these changes Oct 11, 2023
@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 11, 2023
@desig9stein desig9stein changed the title refactor(rating): update taring theme to consume schema colors refactor(rating): update raring theme to consume schema colors Oct 11, 2023
@kdinev kdinev changed the title refactor(rating): update raring theme to consume schema colors refactor(rating): update raтing theme to consume schema colors Oct 20, 2023
@kdinev kdinev changed the title refactor(rating): update raтing theme to consume schema colors refactor(rating): update rating theme to consume schema colors Oct 20, 2023
simeonoff
simeonoff previously approved these changes Oct 23, 2023
@simeonoff simeonoff changed the base branch from master to 16.1.x October 23, 2023 10:38
@simeonoff simeonoff dismissed stale reviews from SisIvanova and themself October 23, 2023 10:38

The base branch was changed.

@kdinev
Copy link
Member

kdinev commented Oct 24, 2023

@simeonoff This has been verified for some time now, but is missing review. Can you or @SisIvanova take a look?

@simeonoff simeonoff self-requested a review October 24, 2023 11:47
@simeonoff
Copy link
Collaborator

@simeonoff This has been verified for some time now, but is missing review. Can you or @SisIvanova take a look?

Yeah, the only reason why it hasn't been merged yet is because I can't get a build to pass since I changed the base branch to 16.1.x...

@simeonoff simeonoff merged commit 7907443 into 16.1.x Oct 24, 2023
6 checks passed
@simeonoff simeonoff deleted the mpopov/rating/update-theme branch October 24, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rating ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants