Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buttons): adding missing type=button #13567 #13573

Merged
merged 1 commit into from Oct 20, 2023
Merged

fix(buttons): adding missing type=button #13567 #13573

merged 1 commit into from Oct 20, 2023

Conversation

kdinev
Copy link
Member

@kdinev kdinev commented Oct 19, 2023 •
edited

Closes #13567

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 20, 2023
@simeonoff simeonoff merged commit b274a13 into 15.1.x Oct 20, 2023
4 checks passed
@simeonoff simeonoff deleted the fix-buttons-15-1-13567 branch October 20, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

@valadzhov valadzhov Awaiting requested review from valadzhov

Assignees
No one assigned
Labels
action-strip banner Banner component 🕐 time-picker combo grid: excel-style-filtering grid: filter-ui grid: row-adding grid: row-editing query-builder select Select component simple-combo snackbar tabs version: 15.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdinev @simeonoff