Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for-of init optimizations for grids #4374

Merged
merged 23 commits into from Apr 3, 2019
Merged

Conversation

ChronosSF
Copy link
Member

@ChronosSF ChronosSF commented Mar 21, 2019

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@ChronosSF ChronosSF added the squash-merge Merge PR with "Squash and Merge" option label Mar 27, 2019
@ChronosSF ChronosSF marked this pull request as ready for review March 28, 2019 08:32
@PavlovVasil PavlovVasil added the 💥 status: in-test PRs currently being tested label Apr 1, 2019
@PavlovVasil PavlovVasil removed the ❌ status: awaiting-test PRs awaiting manual verification label Apr 1, 2019
MayaKirova
MayaKirova previously approved these changes Apr 1, 2019
@PavlovVasil
Copy link
Contributor

PavlovVasil commented Apr 1, 2019

@ChronosSF A found a scenario where the horizontal scrollbar does not show (but it shows in 7.2.x):

  1. Run the igniteui-angular-samples repo
  2. Open http://localhost:4200/samples/tree-grid/treegrid-column-hiding
  3. One by one click all the checkboxes to the left and hide all possible columns - the horizontal scrollbar should disappear
  4. Filter "Name" column by "ZAS" so that no records match
  5. Clear the filter for "Name" by clicking the "Reset" button, then "Close" the filtering
  6. In the column Hiding pane to the left, click the "Show All" button so that all hidden columns get shown again.

Result: The grid has been brought back to its initial state, but this time the horizontal scrollbar is not visible. The same happens in an igxHierarchicalGrid as well.

@PavlovVasil PavlovVasil added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Apr 1, 2019
@ChronosSF ChronosSF added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 2, 2019
@PavlovVasil PavlovVasil added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Apr 2, 2019
@mpavlinov mpavlinov merged commit fe9a61d into 7.2.x Apr 3, 2019
@mpavlinov mpavlinov deleted the sstoychev/calc-chunk-opt branch April 3, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: general squash-merge Merge PR with "Squash and Merge" option version: 7.2.x virtualization ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants