Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics' IE support is outdated #8906

Closed
jackofdiamond5 opened this issue Feb 4, 2021 · 0 comments · Fixed by #9001
Closed

Schematics' IE support is outdated #8906

jackofdiamond5 opened this issue Feb 4, 2021 · 0 comments · Fixed by #9001
Assignees
Labels
🐛 bug Any issue that describes a bug schematics version: 10.2.x version: 11.0.x version: 11.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@jackofdiamond5
Copy link
Member

Description

With Angular having updated their angular.json schema, the es5BrowserSupport property is no longer part of it and we should update our ng add schematic to reflect this change.

  • igniteui-angular version: 11.1.x, 11.0.x, 10.2.x
  • browser: n/a

Steps to reproduce

  1. Create a new project with latest Angular
  2. Do an ng add igniteui-angular in it
  3. During installation choose to enable polyfills
  4. Observe the changes in angular.json

Result

es5BrowserSupport is added to the angular.json

Expected result

es5BrowserSupport is not added to the angular.json

The inclusion for ES5 polyfills should be determined from the browsers listed in the browserslist configuration. (ref)

@Lipata Lipata assigned IvayloG and unassigned Lipata Feb 8, 2021
@Lipata Lipata added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Feb 11, 2021
@IvayloG IvayloG added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug schematics version: 10.2.x version: 11.0.x version: 11.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants