Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindToComponentInputs, withComponentInputBinding & provideHttpClient should be included only for projects that need them #1210

Closed
jackofdiamond5 opened this issue Feb 20, 2024 · 1 comment
Closed

bindToComponentInputs, withComponentInputBinding & provideHttpClient should be included only for projects that need them #1210

jackofdiamond5 opened this issue Feb 20, 2024 · 1 comment
Assignees
@Lipata @dafo
Labels
core @igniteui/cli-core package templates component OR scenario template ✅ status: verified

Comments

@jackofdiamond5
Copy link
Member

jackofdiamond5 commented Feb 20, 2024 •
edited
Loading

Description

Currently we've included the bindToComponentInputs, withComponentInputBinding & provideHttpClient in the base template for all of our projects. Instead, we should be adding them only if the project has route parameters and is explicitly using the HttpClient somewhere in the code.

We may also want to consider reworking the error routing for the projects.

  • Ignite UI CLI version: 13.1.6
  • Framework: Angular
  • Project type: igx-ts

Expected result

bindToComponentInputs, withComponentInputBinding & provideHttpClient should be included only for apps that need them
@jackofdiamond5 jackofdiamond5 added templates component OR scenario template core @igniteui/cli-core package 🆕 status: new labels Feb 20, 2024
@jackofdiamond5 jackofdiamond5 mentioned this issue Feb 20, 2024
Merged
@jackofdiamond5 jackofdiamond5 changed the title withComponentInputBinding & provideHttpClient should be included only for projects that need them bindToComponentInputs, withComponentInputBinding & provideHttpClient should be included only for projects that need them Feb 22, 2024
@github-actions GitHub Actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@IgniteUI IgniteUI deleted a comment from dafo Jul 15, 2024
@dafo dafo self-assigned this Jul 22, 2024
@jackofdiamond5 jackofdiamond5 mentioned this issue Jul 22, 2024
Merged
@Lipata Lipata closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@dafo dafo

Labels
core @igniteui/cli-core package templates component OR scenario template ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Lipata @dafo @jackofdiamond5