Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide http client #1209

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Provide http client #1209

merged 2 commits into from
Feb 21, 2024

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Feb 20, 2024

Adds the provideHttpClient method in the providers array for projects with standalone components.

Also sets the project type of legacy angular projects to igx-ts-legacy in the cli config.

@jackofdiamond5 jackofdiamond5 added the templates component OR scenario template label Feb 20, 2024
@coveralls
Copy link

coveralls commented Feb 20, 2024

Coverage Status

coverage: 65.704%. remained the same
when pulling f8984c9 on bpenkov/templates-update
into c406a98 on master.

@jackofdiamond5
Copy link
Member Author

Since we've introduced a few hardcoded providers in the base template, we may want to consider adding them only when they are actually needed #1210 This should come with some changes in the TSFIleUpdate.

@Lipata Lipata merged commit 3a94150 into master Feb 21, 2024
4 checks passed
@Lipata Lipata deleted the bpenkov/templates-update branch February 21, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
templates component OR scenario template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants