Add a WebComponentsTypeScriptFileUpdate #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackofdiamond5
added
templates
jackofdiamond5
force-pushed
the
bpenkov/angular-ts-file-update
branch
from
7b47a49
to
5da0da3
Compare
jackofdiamond5
force-pushed
the
bpenkov/wc-ts-file-update
branch
3 times, most recently
from
db6c146
to
9468e14
Compare
jackofdiamond5
force-pushed
the
bpenkov/angular-ts-file-update
branch
from
7c25eda
to
b84b190
Compare
jackofdiamond5
force-pushed
the
bpenkov/wc-ts-file-update
branch
5 times, most recently
from
3b85536
to
92662ee
Compare
jackofdiamond5
force-pushed
the
bpenkov/angular-ts-file-update
branch
from
e6ef026
to
fbda8f4
Compare
jackofdiamond5
force-pushed
the
bpenkov/wc-ts-file-update
branch
from
92662ee
to
0d796b0
Compare
refactor(react-update): inherit base file update; add typings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30402.
The
WebComponentsTypeScriptFileUpdateoverridesaddRouteandbuildRouteStructureof theTypeScriptFileUpdateto provide platform-specific behavior when trying to add routes supported by thevaadinrouter.For more info, refer to - AngularTypeScriptFileUpdate PR as the two share the same base and expose the same API.