Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample refactoring #98

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Sample refactoring #98

merged 1 commit into from
Jan 23, 2018

Conversation

DDavidkov
Copy link
Contributor

Refactor the samples, so that they follow the pattern demonstrated in official react samples/tutorials using npm. The pull request includes:

  • Remove all previous samples (their HTML files) and their folders.
  • Add new ones, which were created using create-react-app command and have the same content as the old samples.
  • Edit the Readme.md to reflect these changes (i.e. adding information about how to run the new samples).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.478% when pulling 0611fcf on DDavidkov/SamplesRefactoring into 1889dc0 on master.

@DDavidkov DDavidkov mentioned this pull request Jan 18, 2018
Merged
@DDavidkov DDavidkov requested a review from kdinev January 19, 2018 12:00
@bazal4o bazal4o merged commit 62e74d9 into master Jan 23, 2018
@bazal4o bazal4o deleted the DDavidkov/SamplesRefactoring branch January 23, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChronosSF ChronosSF ChronosSF approved these changes

@kdinev kdinev Awaiting requested review from kdinev

Assignees
No one assigned
Labels
demos enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DDavidkov @coveralls @ChronosSF @bazal4o