Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab component - Unify implementation in a single component #504

Open
rkaraivanov opened this issue Sep 8, 2022 · 0 comments · May be fixed by #627
Open

Tab component - Unify implementation in a single component #504

rkaraivanov opened this issue Sep 8, 2022 · 0 comments · May be fixed by #627
Assignees
@desig9stein @mmart1n @MonikaKirkova
Labels
enhancement New feature or request refactoring tab ✅ status: resolved

Comments

@rkaraivanov
Copy link
Member

Description

When the tabs were implemented, due to the way slot projection work, we took the approach to have separate header and panel components for each tab.

However, this creates problems for accessibility and ease of use from a developer point of view.

I suggest refactoring the tab into a single <igc-tab> component with the appropriate slots for header/content.
@rkaraivanov rkaraivanov added enhancement New feature or request 🆕 status: new The issue is new and will be reviewed when somebody picks it up. refactoring tab labels Sep 8, 2022
@teodosiah teodosiah added status: in-development and removed 🆕 status: new The issue is new and will be reviewed when somebody picks it up. labels Jan 18, 2023
@mmart1n mmart1n closed this as completed Jan 19, 2023
@mmart1n mmart1n linked a pull request Jan 19, 2023 that will close this issue
Open
@teodosiah teodosiah reopened this Jan 20, 2023
@kacheshmarova kacheshmarova mentioned this issue Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@desig9stein desig9stein

@mmart1n mmart1n

@MonikaKirkova MonikaKirkova

Labels
enhancement New feature or request refactoring tab ✅ status: resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Tab Component IgniteUI/igniteui-webcomponents
7 participants
@damyanpetev @simeonoff @rkaraivanov @desig9stein @mmart1n @MonikaKirkova @teodosiah