Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date picker component #1086

Open
wants to merge 101 commits into
base: master
Choose a base branch
from
Open

Add date picker component #1086

wants to merge 101 commits into from

Conversation

ddaribo
Copy link
Contributor

@ddaribo ddaribo commented Feb 26, 2024

Closes #174

@SisIvanova
Copy link
Contributor

The default toggle icon used in the Date Picker Input doesn't correspond to the one in the kit:

Implementation image

UI kit: image

The icon is fixed here, but should also be updated in the Ignite UI Angular Date Picker.

@imincheva
Copy link

imincheva commented Apr 19, 2024 •
edited

Arrows aren't working on the DateTimeInput. Please ignore this, if it's irrelevant to this PR.

Arrows_not_working.mov

@SisIvanova
Copy link
Contributor

Arrows aren't working on the DateTimeInput. Please ignore this, if it's irrelevant to this PR.

Arrows_not_working.mov

I think this should be logged as a separate issue for the DateTimeInput.

@rkaraivanov
Copy link
Member

Arrows aren't working on the DateTimeInput. Please ignore this, if it's irrelevant to this PR.
Arrows_not_working.mov

I think this should be logged as a separate issue for the DateTimeInput.

It is a sample issue in the Storybook for the auto generated docs page. The actual sample works so if you log it add a storybook/samples tag as it is not the component itself.

@imincheva imincheva mentioned this pull request Apr 19, 2024
Closed
@AnjiManova

This comment was marked as resolved.

Sign in to view
@AnjiManova
Copy link

@SisIvanova already fixed the scrollable issue in the Dropdown and I believe we are all good with the Date Picker component validation. All comments are implemented or logged as separate issues.

@radomirchev radomirchev requested review from damyanpetev and removed request for rkaraivanov April 22, 2024 11:44
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
f564b94 
…onents into rkaraivanov/date-picker
@rkaraivanov
fix: Biomejs transition errors
29db60f 
* Refactored focus-trap to be easier to test and
hidden from Blazor
@rkaraivanov
fix(dialog): Update on slotchange
71e2560 
Switching the datepicker between dropdown/dialog modes
when there are slotted actions does not correctly update
the dialog state.
@rkaraivanov
fix: Material/Fluent styles being broken
8265478 
Since migrating the popover component to the top layer
the part attribute was removed. However, the date-picker
uses it for its internal styling. Re-introduced and documented
a new CSS part and fixed the affected styles in the
date-picker.
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
468c8b5 
…onents into rkaraivanov/date-picker
@rkaraivanov
Merge branch 'master' of https://github.com/IgniteUI/igniteui-webcomp…
5d42ddc 
…onents into rkaraivanov/date-picker
@rkaraivanov
chore: Fixed errors after merging from master
6cec176
@rkaraivanov
fix: Calendar selection is applied when the component is readonly
059be15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff Awaiting requested review from simeonoff

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

At least 1 approving review is required to merge this pull request.

Assignees

@imincheva imincheva

@AnjiManova AnjiManova

@sbayreva sbayreva

Labels
date-picker design: verified DO-NOT-MERGE feature squash-merge status: awaiting-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date picker component
8 participants
@ddaribo @AnjiManova @imincheva @SisIvanova @rkaraivanov @simeonoff @sdimchevski @sbayreva