refactor(nav-drawer): update themes #1167
Conversation
| @@ -38,13 +38,13 @@ const light = { | |||
|
|
|||
| const dark = { | |||
| shared: css` | |||
| ${sharedDark} | |||
| ${sharedLight} | |||
There was a problem hiding this comment.
It can be called just shared, if it's shared between both light and dark
| @@ -2,9 +2,14 @@ | |||
| @use '../../light/themes' as *; | |||
|
|
|||
| $theme: $bootstrap; | |||
| $background: var-get($theme, 'background') !default; | |||
There was a problem hiding this comment.
you don't need these variables here, as you're not using them.
| background: var-get($overlay-fluent, 'background-color'); | ||
| } | ||
| } | ||
| $background: var-get($theme, 'background') !default; |
There was a problem hiding this comment.
You don't need these variables, nor this file. You're not overwriting anything.
| background: var-get($overlay-indigo, 'background-color'); | ||
| } | ||
| } | ||
| $background: var-get($theme, 'background') !default; |
There was a problem hiding this comment.
Same as my previous comment
src/components/nav-drawer/themes/shared/container/nav-drawer.material.scss
Outdated
Show resolved
Hide resolved
| @use 'styles/utilities' as *; | ||
| @use '../../light/themes' as *; | ||
|
|
||
| $theme: $material; |
There was a problem hiding this comment.
it's fluent, but you don't even need this variable as you're not getting anything from the theme.
| @use 'styles/utilities' as *; | ||
| @use '../../light/themes' as *; | ||
|
|
||
| $theme: $material; |
There was a problem hiding this comment.
same as my previous comment
| @use 'styles/utilities' as *; | ||
| @use '../../light/themes' as *; | ||
|
|
||
| $theme: $material; |
There was a problem hiding this comment.
Same as my previous comment. Remove all $theme variables where they're not being used.
make sure that fluent has border all around the nav-drawer to match the UI kit.
|
Comments are still not resolved. |
- Delete nav-drawer.fluent.scss and nav-drawer.indigo.scss
src/components/nav-drawer/themes/shared/container/nav-drawer.fluent.scss
Outdated
Show resolved
Hide resolved
…luent.scss Co-authored-by: Dilyana Yarabanova <45598235+didimmova@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
sbayreva
added
design: verified
design: in-validation
and removed
design: in-validation
design: verified
labels
This comment was marked as resolved.
This comment was marked as resolved.
closes #1152